Discussion:
[PATCH: Kerberos keytab bug test and fix]
(too old to reply)
Aaron Haslett via samba-technical
2018-05-15 02:17:50 UTC
Permalink
Raw Message
Clearing the keytab with chgtdcpass doesn't work.  This test and fix
solves the problem.

CI tests here:

https://gitlab.com/catalyst-samba/samba/pipelines/22019771
Andrew Bartlett via samba-technical
2018-05-15 03:09:20 UTC
Permalink
Raw Message
On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical
Post by Aaron Haslett via samba-technical
Clearing the keytab with chgtdcpass doesn't work.  This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771
I've improved the all-important whitespace, some coding style issues
and commit messages.

Reviewed-by: Andrew Bartlett <***@samba.org>

https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest

Can I get a second team reviewer please?

Thanks,

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
Andreas Schneider via samba-technical
2018-05-15 07:56:39 UTC
Permalink
Raw Message
On Tuesday, 15 May 2018 05:09:20 CEST Andrew Bartlett via samba-technical
Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical
Clearing the keytab with chgtdcpass doesn't work. This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771
I've improved the all-important whitespace, some coding style issues
and commit messages.
https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest
Can I get a second team reviewer please?
Pushed to autobuild.


Andreas
--
Andreas Schneider GPG-ID: CC014E3D
Samba Team ***@samba.org
www.samba.org
Andreas Schneider via samba-technical
2018-05-15 16:09:23 UTC
Permalink
Raw Message
On Tuesday, 15 May 2018 05:09:20 CEST Andrew Bartlett via samba-technical
Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical
Clearing the keytab with chgtdcpass doesn't work. This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771
I've improved the all-important whitespace, some coding style issues
and commit messages.
https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest
Can I get a second team reviewer please?
Andrew I missed that there is your RB+ missing for the test. However I've
pushed it and it landed in master.


Could you confirm that you gave RB+ for both patches?


Thanks,


Andreas
--
Andreas Schneider GPG-ID: CC014E3D
Samba Team ***@samba.org
www.samba.org
Andrew Bartlett via samba-technical
2018-05-15 18:25:03 UTC
Permalink
Raw Message
Post by Andreas Schneider via samba-technical
On Tuesday, 15 May 2018 05:09:20 CEST Andrew Bartlett via samba-technical
Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical
Clearing the keytab with chgtdcpass doesn't work. This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771
I've improved the all-important whitespace, some coding style issues
and commit messages.
https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest
Can I get a second team reviewer please?
Andrew I missed that there is your RB+ missing for the test. However I've
pushed it and it landed in master.
Could you confirm that you gave RB+ for both patches?
Yes, I'm fine with both patches. Glad to see them in.

Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
Loading...