Discussion:
[PR PATCH] Fix several spelling erroes
(too old to reply)
Github bot account via samba-technical
2018-05-04 20:48:23 UTC
Permalink
Raw Message
There is a new pull request by sathieu against master on the Samba Samba Github repository

https://github.com/sathieu/samba spelling
https://github.com/samba-team/samba/pull/175

Fix several spelling erroes
Caught by lintian.

A patch file from https://github.com/samba-team/samba/pull/175.patch is attached
Github bot account via samba-technical
2018-05-04 20:55:06 UTC
Permalink
Raw Message
There is an updated pull request by sathieu against master on the Samba Samba Github repository

https://github.com/sathieu/samba spelling
https://github.com/samba-team/samba/pull/175

Fix several spelling erroes
Caught by lintian.

A patch file from https://github.com/samba-team/samba/pull/175.patch is attached
Github bot account via samba-technical
2018-05-04 21:00:35 UTC
Permalink
Raw Message
New comment by sathieu on Samba Github repository

https://github.com/samba-team/samba/pull/175#issuecomment-386733258
Comment:
Remaining spelling errors:
- dont don't (hard to match only strings and not code)
- ot to (ditto)
- prefered preferred (wanted synonym of `preferred master`)
- reponse response (`lm_reponse`, `nt_reponse`, is this intented?)
- ressource resource (touches code, and vfs_fruit param)
- upto up to (hard to match only strings and not code)
- wont won't (hard to match only strings
Rowland Penny via samba-technical
2018-05-05 11:07:06 UTC
Permalink
Raw Message
On Fri, 04 May 2018 20:48:23 +0000
Github bot account via samba-technical
Post by Github bot account via samba-technical
There is a new pull request by sathieu against master on the Samba Samba Github repository
https://github.com/sathieu/samba spelling
https://github.com/samba-team/samba/pull/175
Fix several spelling erroes
Caught by lintian.
A patch file from https://github.com/samba-team/samba/pull/175.patch is attached
Just a couple of nitpicks ;-)

'allows one', is a bit pretentious, we would normally use 'allows you'.

'malformatted', this isn't an English word, perhaps 'incorrectly
formatted' or 'malformed'

Rowland

PS 'erroes' is spelt 'errors' ;-)
Github bot account via samba-technical
2018-05-05 18:52:31 UTC
Permalink
Raw Message
New comment by DHowett on Samba Github repository

https://github.com/samba-team/samba/pull/175#issuecomment-386827041
Comment:
`ressource` is a dangerous one to change. For historical reasons, it was briefly a supported spelling for that config option and it needed to be retained for compatibility.

https://www.samba.org/samba/history/sa
Github bot account via samba-technical
2018-05-15 12:49:08 UTC
Permalink
Raw Message
New comment by sathieu on Samba Github repository

https://github.com/samba-team/samba/pull/175#issuecomment-389154352
Comment:
@abartlet Thanks Andrew. You have skipped https://github.com/samba-team/samba/pull/175/commits/d5b54c72ba8a9a8b94748a90013adfc6d8d7b1ae `Fix spelling s/expli
Loading...