Discussion:
[PR PATCH] samdb: fix wrong computer container dn for newcomputer
(too old to reply)
Github bot account via samba-technical
2018-05-03 03:23:38 UTC
Permalink
Raw Message
There is a new pull request by catalyst-joe-guo against master on the Samba Samba Github repository

https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173

samdb: fix wrong computer container dn for newcomputer
Fix a copy-and-paste issue for samdb.newcomputer method:

CN=Users --> CN=Computers

Signed-off-by: Joe Guo <***@catalyst.net.nz>

A patch file from https://github.com/samba-team/samba/pull/173.patch is attached
William Brown via samba-technical
2018-05-03 04:37:03 UTC
Permalink
Raw Message
On Thu, 2018-05-03 at 03:23 +0000, Github bot account via samba-
Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on the
Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from https://github.com/samba-team/samba/pull/173.patch is attached
Simple! Looks good to me,

William
Alexander Bokovoy via samba-technical
2018-05-03 06:45:44 UTC
Permalink
Raw Message
Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on the Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from https://github.com/samba-team/samba/pull/173.patch is attached
RB+. One more team reviewer, please.
--
/ Alexander Bokovoy
Rowland Penny via samba-technical
2018-05-03 06:59:37 UTC
Permalink
Raw Message
On Thu, 3 May 2018 09:45:44 +0300
Post by Alexander Bokovoy via samba-technical
Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on
the Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from
https://github.com/samba-team/samba/pull/173.patch is attached
RB+. One more team reviewer, please.
Fairly obvious RB+

Rowland
Alexander Bokovoy via samba-technical
2018-05-03 08:31:33 UTC
Permalink
Raw Message
Post by Rowland Penny via samba-technical
On Thu, 3 May 2018 09:45:44 +0300
Post by Alexander Bokovoy via samba-technical
Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on
the Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from
https://github.com/samba-team/samba/pull/173.patch is attached
RB+. One more team reviewer, please.
Fairly obvious RB+
Thanks. Pushed to autobuild.
--
/ Alexander Bokovoy
Github bot account via samba-technical
2018-05-07 04:16:23 UTC
Permalink
Raw Message
New comment by catalyst-joe-guo on Samba Github repository

https://github.com/samba-team/samba/pull/173#issuecomment-386953069
Comment:
Already merged as ca387c221f974216
Github bot account via samba-technical
2018-05-07 04:16:23 UTC
Permalink
Raw Message
There's a closed pull request on the Samba Samba Github repository

samdb: fix wrong computer container dn for newcomputer
https://github.com/samba-team/samba/pull/173
Description: Fix a copy-and-paste issue for samdb.newcomputer method:

CN=Users --> CN=Computers

Signed-off-by:
Björn Baumbach via samba-technical
2018-05-07 13:15:59 UTC
Permalink
Raw Message
Post by Github bot account via samba-technical
samdb: fix wrong computer container dn for newcomputer
Thank you for fixing this!

There is the same issue in the samba-tool computer.py code.

Patch is attached, please review and push :-)

Best regards,
Björn
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:***@sernet.de
Loading...