Discussion:
[PR PATCH] Added ReadDirPlus API in libsmbclient which returns detailed file properties
(too old to reply)
Github bot account via samba-technical
2018-03-06 06:21:53 UTC
Permalink
Raw Message
There is a new pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Github bot account via samba-technical
2018-03-06 06:28:58 UTC
Permalink
Raw Message
New comment by puran157 on Samba Github repository

https://github.com/samba-team/samba/pull/140#issuecomment-370677868
Comment:
smbc_readdirplus API is similar to that of smbc_readdir, but it returns struct libsmb_file_info structure which has more information, like size, mode, uid, gid, create-time, change-time, modified time, access time etc.

In existing implementation, a call to smbc_opendir returns all information about files in current directory from SMB server but smbc_readdir returns smbc_dirent structure. A repeated call should be made to smbc_stat to get more information about all files in current directory and it turns out to be an additional network call to SMB Server.

With this PR, I maintain an another double linked list of struct libsmb_file_info structure and that gets filled up when smbc_opendir is called. smbc_readdirplus would return the file_info structure while iterating o
Github bot account via samba-technical
2018-03-06 07:30:25 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Github bot account via samba-technical
2018-03-06 09:34:53 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Puran Chand via samba-technical
2018-03-12 05:05:41 UTC
Permalink
Raw Message
Hi All,

Kindly review the changes.

- Puran

On Tue, Mar 6, 2018 at 3:04 PM, Github bot account via samba-technical <
Post by Github bot account via samba-technical
There is an updated pull request by puran157 against master on the Samba
Samba Github repository
https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140
Added ReadDirPlus API in libsmbclient which returns detailed file properties
A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Puran Chand via samba-technical
2018-03-21 04:40:24 UTC
Permalink
Raw Message
Hi All,

This is just a friendly reminder, kindly review the changes

-Puran
Post by Puran Chand via samba-technical
Hi All,
Kindly review the changes.
- Puran
On Tue, Mar 6, 2018 at 3:04 PM, Github bot account via samba-technical <
Post by Github bot account via samba-technical
There is an updated pull request by puran157 against master on the Samba
Samba Github repository
https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140
Added ReadDirPlus API in libsmbclient which returns detailed file properties
A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Jeremy Allison via samba-technical
2018-03-21 17:13:27 UTC
Permalink
Raw Message
Post by Puran Chand via samba-technical
Hi All,
This is just a friendly reminder, kindly review the changes
-Puran
Hi Puran, thanks for the ping. I'm planning to get to these
next week.

Cheers,

Jeremy.
Github bot account via samba-technical
2018-03-30 03:26:55 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Github bot account via samba-technical
2018-04-04 09:49:58 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Github bot account via samba-technical
2018-04-05 04:42:24 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Jeremy Allison via samba-technical
2018-04-05 23:42:01 UTC
Permalink
Raw Message
Post by Github bot account via samba-technical
There is an updated pull request by puran157 against master on the Samba Samba Github repository
https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140
Added ReadDirPlus API in libsmbclient which returns detailed file properties
A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Hi Puran,

I'm pretty happy with this one now, just some formatting
issues I can fix. If I send you a modified version will you
review with a view to getting into samba-master ?

Thanks a *LOT* for your patience.

Cheers,

Jeremy.
Jeremy Allison via samba-technical
2018-04-06 23:49:04 UTC
Permalink
Raw Message
Sure Jeremy.
Thanks.
Just FYI, still working on this as I'm breaking it up
into smaller commits to make it easier for others to
review.

Should be finished early next week.

Jeremy.
Puran
On Thu, Apr 05, 2018 at 04:42:24AM +0000, Github bot account via
Post by Github bot account via samba-technical
There is an updated pull request by puran157 against master on the Samba
Samba Github repository
Post by Github bot account via samba-technical
https://urldefense.proofpoint.com/v2/url?u=
https-3A__github.com_puran157_samba&d=DwIBAg&c=uilaK90D4TOVoH58JNXRgQ&r=
cC3nN-kclt9Sa3aDBSDVmQnujCl2sIwsIBtZM3v1qY0&m=
SY0HakfkZmqn6TDEzDr6zvRXg981QGvOoZrbxyTv5kk&s=
pFhrWTeafkHuYygUavVpM7HNzdFfUp7kuUci8dyvZNQ&e= readdir_plus
Post by Github bot account via samba-technical
https://urldefense.proofpoint.com/v2/url?u=
https-3A__github.com_samba-2Dteam_samba_pull_140&d=DwIBAg&c=
uilaK90D4TOVoH58JNXRgQ&r=cC3nN-kclt9Sa3aDBSDVmQnujCl2sIwsIBtZM3v1qY0&m=
SY0HakfkZmqn6TDEzDr6zvRXg981QGvOoZrbxyTv5kk&s=
c2Qa2Tvz5Ldi9liNqqYPkulmus7cekVpJZ8QwsFI-R4&e=
Post by Github bot account via samba-technical
Added ReadDirPlus API in libsmbclient which returns detailed file
properties
Post by Github bot account via samba-technical
A patch file from https://urldefense.proofpoint.com/v2/url?u=
https-3A__github.com_samba-2Dteam_samba_pull_140.patch&d=DwIBAg&c=
uilaK90D4TOVoH58JNXRgQ&r=cC3nN-kclt9Sa3aDBSDVmQnujCl2sIwsIBtZM3v1qY0&m=
SY0HakfkZmqn6TDEzDr6zvRXg981QGvOoZrbxyTv5kk&s=
3dyLwr6wvkONKHT3sx8bR6lGKFIQqoAejlOof2J0aUk&e= is attached
Hi Puran,
I'm pretty happy with this one now, just some formatting
issues I can fix. If I send you a modified version will you
review with a view to getting into samba-master ?
Thanks a *LOT* for your patience.
Cheers,
Jeremy.
Jeremy Allison via samba-technical
2018-04-09 20:24:08 UTC
Permalink
Raw Message
Sure Jeremy.
Thanks.
OK, here is a preliminary version of the patchset (minus
the test) that I'd like you to take a look at please.

It splits the patches into small, review-sized chunks
and updates the coding style to match README.Coding.

I'm still looking at the test code. The reason is you've
copied the libsmbclient.opendir tests, which are explicitly
marked as "knownfail" as they depend on NetBIOS browsing
service, so as posted they won't work.

I'm thinking of how to modify these to work against
the existing test shares. I'll post more when I've
gotten it working.

In the meantime can you review and test this patchset,
and make sure I didn't break anything ?

Thanks,

Jeremy.
jim via samba-technical
2018-04-09 23:43:37 UTC
Permalink
Raw Message
This should be finfo-> instead of info->.
--- a/examples/fuse/clifuse.c
+++ b/examples/fuse/clifuse.c
@@ -484,6 +484,7 @@ static NTSTATUS parse_finfo_id_both_directory_info(uint8_t *dir_data,
return NT_STATUS_INFO_LENGTH_MISMATCH;
}
+ info->btime_ts = interpret_long_date((const char *)dir_data + 8);
finfo->atime_ts = interpret_long_date((const char *)dir_data + 16);
finfo->mtime_ts = interpret_long_date((const char *)dir_data + 24);
finfo->ctime_ts = interpret_long_date((const char *)dir_data + 32);
Jeremy Allison via samba-technical
2018-04-09 23:45:21 UTC
Permalink
Raw Message
Post by jim via samba-technical
This should be finfo-> instead of info->.
Thanks - well spotted !
Post by jim via samba-technical
--- a/examples/fuse/clifuse.c
+++ b/examples/fuse/clifuse.c
@@ -484,6 +484,7 @@ static NTSTATUS parse_finfo_id_both_directory_info(uint8_t *dir_data,
return NT_STATUS_INFO_LENGTH_MISMATCH;
}
+ info->btime_ts = interpret_long_date((const char *)dir_data + 8);
finfo->atime_ts = interpret_long_date((const char *)dir_data + 16);
finfo->mtime_ts = interpret_long_date((const char *)dir_data + 24);
finfo->ctime_ts = interpret_long_date((const char *)dir_data + 32);
Github bot account via samba-technical
2018-04-05 04:46:34 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Github bot account via samba-technical
2018-04-10 05:13:44 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Github bot account via samba-technical
2018-04-10 05:25:15 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Puran Chand via samba-technical
2018-04-10 05:27:46 UTC
Permalink
Raw Message
Hi Jeremy,

I tested the changes.
Seems good to me.

Thanks Jim for spotting the typo.
Its fixed now.

-Puran

On Tue, Apr 10, 2018 at 10:55 AM, Github bot account via samba-technical <
Post by Github bot account via samba-technical
There is an updated pull request by puran157 against master on the Samba
Samba Github repository
https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140
Added ReadDirPlus API in libsmbclient which returns detailed file properties
A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Jeremy Allison via samba-technical
2018-04-10 16:34:12 UTC
Permalink
Raw Message
Post by Puran Chand via samba-technical
Hi Jeremy,
I tested the changes.
Seems good to me.
Thanks Jim for spotting the typo.
Its fixed now.
Updated version just for our records.

I still need to create a simple test scenario
for this before I can propose review. I'm on
vacation all next week so this may have to
wait until after I return, sorry.

Jeremy.
Github bot account via samba-technical
2018-04-25 03:08:47 UTC
Permalink
Raw Message
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba readdir_plus
https://github.com/samba-team/samba/pull/140

Added ReadDirPlus API in libsmbclient which returns detailed file properties


Signed-off-by: Puran Chand <***@vmware.com>

A patch file from https://github.com/samba-team/samba/pull/140.patch is attached
Github bot account via samba-technical
2018-05-07 03:05:42 UTC
Permalink
Raw Message
New comment by puran157 on Samba Github repository

https://github.com/samba-team/samba/pull/140#issuecomment-3869
Github bot account via samba-technical
2018-05-07 03:05:42 UTC
Permalink
Raw Message
There's a closed pull request on the Samba Samba Github repository

Added ReadDirPlus API in libsmbclient which returns detailed file properties
https://github.com/samba-team/samba/pull/140
Description:

Signed-off-by: Puran

Loading...