[cifs:for-next 3/8] fs/cifs/cifs_debug.c:54:4: error: too few arguments to function 'server->ops->calc_smb

kbuild test robot via samba-technical

2018-05-14 16:56:08 UTC

tree: git://git.samba.org/sfrench/cifs-2.6.git for-next
head: ef86c0628b32f98cd4014df2990e0aa68e380083
commit: 4e989295d0e2d066454ed8e097deef54824694f0 [3/8] cifs: update calc_size to take a server argument
config: x86_64-nfsroot (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout 4e989295d0e2d066454ed8e097deef54824694f0
# save the attached .config to linux build tree
make ARCH=x86_64

Note: the cifs/for-next HEAD ef86c0628b32f98cd4014df2990e0aa68e380083 builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

In file included from include/linux/kernel.h:14:0,
from include/linux/list.h:9,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,

fs/cifs/cifs_debug.c:54:4: error: too few arguments to function 'server->ops->calc_smb_size'

server->ops->calc_smb_size(smb));
^
include/linux/printk.h:357:17: note: in definition of macro 'printk_once'
printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
fs/cifs/cifs_debug.h:57:3: note: in expansion of macro 'pr_err_once'
pr_err_ ## ratefunc("CIFS VFS: " \
^~~~~~~
fs/cifs/cifs_debug.h:67:3: note: in expansion of macro 'cifs_dbg_func'
cifs_dbg_func(once, \
^~~~~~~~~~~~~
fs/cifs/cifs_debug.c:53:2: note: in expansion of macro 'cifs_dbg'
cifs_dbg(VFS, "smb buf %p len %u\n", smb,
^~~~~~~~

fs/cifs/cifs_debug.c:54:4: error: too few arguments to function 'server->ops->calc_smb_size'

server->ops->calc_smb_size(smb));
^
include/linux/printk.h:425:17: note: in definition of macro 'printk_ratelimited'
printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
fs/cifs/cifs_debug.h:57:3: note: in expansion of macro 'pr_err_ratelimited'
pr_err_ ## ratefunc("CIFS VFS: " \
^~~~~~~
fs/cifs/cifs_debug.h:70:3: note: in expansion of macro 'cifs_dbg_func'
cifs_dbg_func(ratelimited, \
^~~~~~~~~~~~~
fs/cifs/cifs_debug.c:53:2: note: in expansion of macro 'cifs_dbg'
cifs_dbg(VFS, "smb buf %p len %u\n", smb,
^~~~~~~~

fs/cifs/cifs_debug.c:54:4: error: too few arguments to function 'server->ops->calc_smb_size'

server->ops->calc_smb_size(smb));
^
include/linux/printk.h:136:17: note: in definition of macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
fs/cifs/cifs_debug.h:60:3: note: in expansion of macro 'pr_debug_ratelimited'
pr_debug_ ## ratefunc(fmt, ##__VA_ARGS__); \
^~~~~~~~~
fs/cifs/cifs_debug.h:70:3: note: in expansion of macro 'cifs_dbg_func'
cifs_dbg_func(ratelimited, \
^~~~~~~~~~~~~
fs/cifs/cifs_debug.c:53:2: note: in expansion of macro 'cifs_dbg'
cifs_dbg(VFS, "smb buf %p len %u\n", smb,
^~~~~~~~
fs/cifs/cifs_debug.c: In function 'cifs_dump_mids':
fs/cifs/cifs_debug.c:87:4: error: too few arguments to function 'cifs_dump_detail'
cifs_dump_detail(mid_entry->resp_buf);
^~~~~~~~~~~~~~~~
fs/cifs/cifs_debug.c:45:6: note: declared here
void cifs_dump_detail(void *buf, struct TCP_Server_Info *server)
^~~~~~~~~~~~~~~~
--
In file included from include/linux/kernel.h:14:0,
from include/asm-generic/bug.h:18,
from arch/x86/include/asm/bug.h:83,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from include/linux/pagemap.h:8,

fs/cifs/smb2ops.c:224:4: error: too few arguments to function 'server->ops->calc_smb_size'

server->ops->calc_smb_size(buf));
^
include/linux/printk.h:357:17: note: in definition of macro 'printk_once'
printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
fs/cifs/cifs_debug.h:57:3: note: in expansion of macro 'pr_err_once'
pr_err_ ## ratefunc("CIFS VFS: " \
^~~~~~~
fs/cifs/cifs_debug.h:67:3: note: in expansion of macro 'cifs_dbg_func'
cifs_dbg_func(once, \
^~~~~~~~~~~~~
fs/cifs/smb2ops.c:223:2: note: in expansion of macro 'cifs_dbg'
cifs_dbg(VFS, "smb buf %p len %u\n", buf,
^~~~~~~~

fs/cifs/smb2ops.c:224:4: error: too few arguments to function 'server->ops->calc_smb_size'

server->ops->calc_smb_size(buf));
^
include/linux/printk.h:425:17: note: in definition of macro 'printk_ratelimited'
printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
fs/cifs/cifs_debug.h:57:3: note: in expansion of macro 'pr_err_ratelimited'
pr_err_ ## ratefunc("CIFS VFS: " \
^~~~~~~
fs/cifs/cifs_debug.h:70:3: note: in expansion of macro 'cifs_dbg_func'
cifs_dbg_func(ratelimited, \
^~~~~~~~~~~~~
fs/cifs/smb2ops.c:223:2: note: in expansion of macro 'cifs_dbg'
cifs_dbg(VFS, "smb buf %p len %u\n", buf,
^~~~~~~~

fs/cifs/smb2ops.c:224:4: error: too few arguments to function 'server->ops->calc_smb_size'

server->ops->calc_smb_size(buf));
^
include/linux/printk.h:136:17: note: in definition of macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
fs/cifs/cifs_debug.h:60:3: note: in expansion of macro 'pr_debug_ratelimited'
pr_debug_ ## ratefunc(fmt, ##__VA_ARGS__); \
^~~~~~~~~
fs/cifs/cifs_debug.h:70:3: note: in expansion of macro 'cifs_dbg_func'
cifs_dbg_func(ratelimited, \
^~~~~~~~~~~~~
fs/cifs/smb2ops.c:223:2: note: in expansion of macro 'cifs_dbg'
cifs_dbg(VFS, "smb buf %p len %u\n", buf,
^~~~~~~~

vim +54 fs/cifs/cifs_debug.c

^1da177e4 Linus Torvalds 2005-04-16 @22 #include <linux/fs.h>
^1da177e4 Linus Torvalds 2005-04-16 23 #include <linux/string.h>
^1da177e4 Linus Torvalds 2005-04-16 24 #include <linux/ctype.h>
^1da177e4 Linus Torvalds 2005-04-16 25 #include <linux/module.h>
^1da177e4 Linus Torvalds 2005-04-16 26 #include <linux/proc_fs.h>
7c0f6ba68 Linus Torvalds 2016-12-24 27 #include <linux/uaccess.h>
^1da177e4 Linus Torvalds 2005-04-16 28 #include "cifspdu.h"
^1da177e4 Linus Torvalds 2005-04-16 29 #include "cifsglob.h"
^1da177e4 Linus Torvalds 2005-04-16 30 #include "cifsproto.h"
^1da177e4 Linus Torvalds 2005-04-16 31 #include "cifs_debug.h"
6c91d362f Steve French 2005-04-28 32 #include "cifsfs.h"
d8ec913b1 Long Li 2017-11-07 33 #ifdef CONFIG_CIFS_SMB_DIRECT
d8ec913b1 Long Li 2017-11-07 34 #include "smbdirect.h"
d8ec913b1 Long Li 2017-11-07 35 #endif
^1da177e4 Linus Torvalds 2005-04-16 36
^1da177e4 Linus Torvalds 2005-04-16 37 void
^1da177e4 Linus Torvalds 2005-04-16 38 cifs_dump_mem(char *label, void *data, int length)
^1da177e4 Linus Torvalds 2005-04-16 39 {
0b456f04b Andy Shevchenko 2014-08-27 40 pr_debug("%s: dump of %d bytes of data at 0x%p\n", label, length, data);
55d83e0db Andy Shevchenko 2014-08-27 41 print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 4,
55d83e0db Andy Shevchenko 2014-08-27 42 data, length, true);
^1da177e4 Linus Torvalds 2005-04-16 43 }
^1da177e4 Linus Torvalds 2005-04-16 44
1032101bd Ronnie Sahlberg 2018-04-22 45 void cifs_dump_detail(void *buf, struct TCP_Server_Info *server)
3979877e5 Steve French 2006-05-31 46 {
8aa26f3ed Pavel Shilovsky 2012-05-17 47 #ifdef CONFIG_CIFS_DEBUG2
d4e4854fd Pavel Shilovsky 2012-03-23 48 struct smb_hdr *smb = (struct smb_hdr *)buf;
d4e4854fd Pavel Shilovsky 2012-03-23 49
f96637be0 Joe Perches 2013-05-04 50 cifs_dbg(VFS, "Cmd: %d Err: 0x%x Flags: 0x%x Flgs2: 0x%x Mid: %d Pid: %d\n",
3979877e5 Steve French 2006-05-31 51 smb->Command, smb->Status.CifsError,
b6b38f704 Joe Perches 2010-04-21 52 smb->Flags, smb->Flags2, smb->Mid, smb->Pid);
1032101bd Ronnie Sahlberg 2018-04-22 53 cifs_dbg(VFS, "smb buf %p len %u\n", smb,
1032101bd Ronnie Sahlberg 2018-04-22 @54 server->ops->calc_smb_size(smb));
8aa26f3ed Pavel Shilovsky 2012-05-17 55 #endif /* CONFIG_CIFS_DEBUG2 */
3979877e5 Steve French 2006-05-31 56 }
3979877e5 Steve French 2006-05-31 57

:::::: The code at line 54 was first introduced by commit
:::::: 1032101bd095f8b49dcf100fe763c4b6c1e6f7b0 cifs: add server argument to the dump_detail method

:::::: TO: Ronnie Sahlberg <***@redhat.com>
:::::: CC: Steve French <***@microsoft.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation