Tom Talpey via samba-technical
2018-04-26 18:45:53 UTC
-----Original Message-----
Behalf Of Long Li
Sent: Wednesday, April 25, 2018 2:30 PM
Subject: [PATCH v5] cifs: Allocate validate negotiation request through kmalloc
The data buffer allocated on the stack can't be DMA'ed, ib_dma_map_page will
return an invalid DMA address for a buffer on stack. Even worse, this
incorrect address can't be detected by ib_dma_mapping_error. Sending data
from this address to hardware will not fail, but the remote peer will get
junk data.
Fix this by allocating the request on the heap in smb3_validate_negotiate.
Looks good.Behalf Of Long Li
Sent: Wednesday, April 25, 2018 2:30 PM
Subject: [PATCH v5] cifs: Allocate validate negotiation request through kmalloc
The data buffer allocated on the stack can't be DMA'ed, ib_dma_map_page will
return an invalid DMA address for a buffer on stack. Even worse, this
incorrect address can't be detected by ib_dma_mapping_error. Sending data
from this address to hardware will not fail, but the remote peer will get
junk data.
Fix this by allocating the request on the heap in smb3_validate_negotiate.
Reviewed-By: Tom Talpey <***@microsoft.com>