[PATCH] Fix strict aliasing warnings in ctdb_client

[Andreas Schneider via samba-technical]

Hi,

see attached.


Review much appreciated.


Thanks,


Andreas

[Andreas Schneider via samba-technical]

On Friday, 27 April 2018 16:47:10 CEST Andreas Schneider via samba-technical

Post by Andreas Schneider via samba-technical
Hi,
see attached.
Review much appreciated.

Well the function is unused an can be removed ...


Andreas

[Amitay Isaacs via samba-technical]

On Sat, Apr 28, 2018 at 12:47 AM, Andreas Schneider via

Post by Andreas Schneider via samba-technical
Hi,
see attached.
Review much appreciated.

This is actually wrong. It fixes the data format to LE, which will
break things on BE machine.

We need to fix the format for all the stored data and on-wire data.
It might be better to change all the formats at once since it will
break backward compatibility.

Amitay.

[Stefan Metzmacher via samba-technical]

Post by Amitay Isaacs via samba-technical
On Sat, Apr 28, 2018 at 12:47 AM, Andreas Schneider via

Post by Andreas Schneider via samba-technical
Hi,
see attached.
Review much appreciated.

This is actually wrong. It fixes the data format to LE, which will
break things on BE machine.
We need to fix the format for all the stored data and on-wire data.
It might be better to change all the formats at once since it will
break backward compatibility.

The function is actually not used and can be removed instead ...

metze

[Amitay Isaacs via samba-technical]

Post by Stefan Metzmacher via samba-technical

Post by Amitay Isaacs via samba-technical
On Sat, Apr 28, 2018 at 12:47 AM, Andreas Schneider via

Post by Andreas Schneider via samba-technical
Hi,
see attached.
Review much appreciated.

This is actually wrong. It fixes the data format to LE, which will
break things on BE machine.
We need to fix the format for all the stored data and on-wire data.
It might be better to change all the formats at once since it will
break backward compatibility.

The function is actually not used and can be removed instead ...

Sure. I still wanted to point out what was wrong with the first patch.

I am preparing a patch which drops most of the unused functions from
ctdb_client.c.

Andreas, please file CTDB bugs against CTDB component rather than Clustering.

Amitay.

[Amitay Isaacs via samba-technical]

Post by Amitay Isaacs via samba-technical

Post by Stefan Metzmacher via samba-technical

Post by Amitay Isaacs via samba-technical
On Sat, Apr 28, 2018 at 12:47 AM, Andreas Schneider via

Post by Andreas Schneider via samba-technical
Hi,
see attached.
Review much appreciated.

This is actually wrong. It fixes the data format to LE, which will
break things on BE machine.
We need to fix the format for all the stored data and on-wire data.
It might be better to change all the formats at once since it will
break backward compatibility.

The function is actually not used and can be removed instead ...

Sure. I still wanted to point out what was wrong with the first patch.
I am preparing a patch which drops most of the unused functions from
ctdb_client.c.
Andreas, please file CTDB bugs against CTDB component rather than Clustering.
Amitay.

Here is a patch set that removes all of the unused code from ctdb_client.c.
ctdb_client.c is now moved to server/ subdirectory. So all the old
style code now lives in server/.

Amitay.

[Martin Schwenke via samba-technical]

On Tue, 1 May 2018 13:01:37 +1000, Amitay Isaacs via samba-technical

Post by Amitay Isaacs via samba-technical
[...]
[...]
[...]

Post by Amitay Isaacs via samba-technical

Post by Stefan Metzmacher via samba-technical
The function is actually not used and can be removed instead ...

Sure. I still wanted to point out what was wrong with the first patch.
I am preparing a patch which drops most of the unused functions from
ctdb_client.c.
Andreas, please file CTDB bugs against CTDB component rather than Clustering.
Amitay.

Here is a patch set that removes all of the unused code from ctdb_client.c.
ctdb_client.c is now moved to server/ subdirectory. So all the old
style code now lives in server/.

Reviewed-by: Martin Schwenke <***@meltin.net>

I'll hold off pushing for a little while until the retest of my config
changes completes. Hopefully we can push both together...


peace & happiness,
martin

[Martin Schwenke via samba-technical]

On Tue, 1 May 2018 15:08:12 +1000, Martin Schwenke via samba-technical

Post by Martin Schwenke via samba-technical
On Tue, 1 May 2018 13:01:37 +1000, Amitay Isaacs via samba-technical
[...]

Post by Amitay Isaacs via samba-technical
[...]
[...]
[...]

[...]

Post by Amitay Isaacs via samba-technical

Post by Amitay Isaacs via samba-technical
Sure. I still wanted to point out what was wrong with the first patch.
I am preparing a patch which drops most of the unused functions from
ctdb_client.c.
Andreas, please file CTDB bugs against CTDB component rather than Clustering.
Amitay.

Here is a patch set that removes all of the unused code from ctdb_client.c.
ctdb_client.c is now moved to server/ subdirectory. So all the old
style code now lives in server/.

I'll hold off pushing for a little while until the retest of my config
changes completes. Hopefully we can push both together...

As discussed, only RB+ if you do whitespace fixups. ;-)

peace & happiness,
martin

[Amitay Isaacs via samba-technical]

On Tue, May 1, 2018 at 4:57 PM, Martin Schwenke via samba-technical

Post by Martin Schwenke via samba-technical
On Tue, 1 May 2018 15:08:12 +1000, Martin Schwenke via samba-technical

Post by Martin Schwenke via samba-technical
On Tue, 1 May 2018 13:01:37 +1000, Amitay Isaacs via samba-technical
[...]

Post by Amitay Isaacs via samba-technical
[...]
[...]
[...]

[...]

Post by Amitay Isaacs via samba-technical

Post by Amitay Isaacs via samba-technical
Sure. I still wanted to point out what was wrong with the first patch.
I am preparing a patch which drops most of the unused functions from
ctdb_client.c.
Andreas, please file CTDB bugs against CTDB component rather than Clustering.
Amitay.

Here is a patch set that removes all of the unused code from ctdb_client.c.
ctdb_client.c is now moved to server/ subdirectory. So all the old
style code now lives in server/.

I'll hold off pushing for a little while until the retest of my config
changes completes. Hopefully we can push both together...

As discussed, only RB+ if you do whitespace fixups. ;-)
peace & happiness,
martin

Done. Pushed along with your patches.

Amitay.