[PATCH] check types rather than segfault in pygpo.c

[Douglas Bagnall via samba-technical]

I was trying to find good examples for another thread, and only found bad.

Douglas

[Andrew Bartlett via samba-technical]

On Fri, 2018-04-13 at 14:39 +1200, Douglas Bagnall via samba-technical

Post by Douglas Bagnall via samba-technical
I was trying to find good examples for another thread, and only found bad.
Douglas

Thanks Douglas!

Reviewed-by: Andrew Bartlett <***@samba.org>

Please push!

[Douglas Bagnall via samba-technical]

Post by Andrew Bartlett via samba-technical
On Fri, 2018-04-13 at 14:39 +1200, Douglas Bagnall via samba-technical

Post by Douglas Bagnall via samba-technical
I was trying to find good examples for another thread, and only found bad.
Douglas

Thanks Douglas!
Please push!

Actually it is better like this, with the test squashed into the fix (or
I guess omitted altogether), because the knownfail entry doesn't cope
with the segfault, so we'd have a failure between those commits.

Douglas

[Andrew Bartlett via samba-technical]

Post by Douglas Bagnall via samba-technical

Post by Andrew Bartlett via samba-technical
On Fri, 2018-04-13 at 14:39 +1200, Douglas Bagnall via samba-technical

Post by Douglas Bagnall via samba-technical
I was trying to find good examples for another thread, and only found bad.
Douglas

Thanks Douglas!
Please push!

Actually it is better like this, with the test squashed into the fix (or
I guess omitted altogether), because the knownfail entry doesn't cope
with the segfault, so we'd have a failure between those commits.

This is also quite fine. Thanks!

Post by Douglas Bagnall via samba-technical
Douglas