Jeremy Allison via samba-technical
2018-05-02 20:50:51 UTC
Here is the more difficult to review patchset,
due to the fact it's having to change some
very old printing code.
Patchset #1 removes all uses of SMB_VFS_READ
from source3/printing/nt_printing.c. This is
*very* old and crustly code, so I started by
reformatting to modern standards, followed
by splitting out a monster function into
several functons called by the now-smaller
parent, and finally tried to change one
element at a time to move towards a clean
set of functions that only call a single
function - printing_pread_data() - that
uses read_file(), which takes an offset
as well as length.
The reformatting changes no behavior,
but should make the actual changes
easier to see and understand.
Patchset #2 removes SMB_VFS_READ
from the VFS.
Please review and push if happy.