Discussion:
[PATCH] Remove a hard-coded error return in libsmbclient.
Jeremy Allison via samba-technical
2018-05-02 18:51:07 UTC
Permalink
Found by the ChromeOS folks, trying to connect to a
SMB1-only server with SMB2-only client code - and
wondering why they immediately got an error return
with errno = ETIMEDOUT :-).

We have a perfectly good NTSTATUS code, we should
use it :-).

Logged as bug https://bugzilla.samba.org/show_bug.cgi?id=13419

Please review and push if happy !

Cheers,

Jeremy.
Alexander Bokovoy via samba-technical
2018-05-03 15:07:27 UTC
Permalink
Post by Jeremy Allison via samba-technical
Found by the ChromeOS folks, trying to connect to a
SMB1-only server with SMB2-only client code - and
wondering why they immediately got an error return
with errno = ETIMEDOUT :-).
We have a perfectly good NTSTATUS code, we should
use it :-).
Logged as bug https://bugzilla.samba.org/show_bug.cgi?id=13419
Please review and push if happy !
RB+. Unfortunately, I remembered about this patch after I already pushed
the other batch.

May be push it with the rest of the patches you plan to push today?
--
/ Alexander Bokovoy
Alexander Bokovoy via samba-technical
2018-05-03 15:29:55 UTC
Permalink
Post by Alexander Bokovoy via samba-technical
Post by Jeremy Allison via samba-technical
Found by the ChromeOS folks, trying to connect to a
SMB1-only server with SMB2-only client code - and
wondering why they immediately got an error return
with errno = ETIMEDOUT :-).
We have a perfectly good NTSTATUS code, we should
use it :-).
Logged as bug https://bugzilla.samba.org/show_bug.cgi?id=13419
Please review and push if happy !
RB+. Unfortunately, I remembered about this patch after I already pushed
the other batch.
May be push it with the rest of the patches you plan to push today?
Ah, saw that Volker already reviewed it and you already pushed. :)
--
/ Alexander Bokovoy
Loading...