[PATCH: Kerberos keytab bug test and fix]

[Aaron Haslett via samba-technical]

Clearing the keytab with chgtdcpass doesn't work.  This test and fix
solves the problem.

CI tests here:

https://gitlab.com/catalyst-samba/samba/pipelines/22019771

[Andrew Bartlett via samba-technical]

On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical

Post by Aaron Haslett via samba-technical
Clearing the keytab with chgtdcpass doesn't work.  This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771

I've improved the all-important whitespace, some coding style issues
and commit messages.

Reviewed-by: Andrew Bartlett <***@samba.org>

https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest

Can I get a second team reviewer please?

Thanks,

Andrew Bartlett

[Andreas Schneider via samba-technical]

On Tuesday, 15 May 2018 05:09:20 CEST Andrew Bartlett via samba-technical

Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical

Clearing the keytab with chgtdcpass doesn't work. This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771

I've improved the all-important whitespace, some coding style issues
and commit messages.
https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest
Can I get a second team reviewer please?

Pushed to autobuild.


Andreas

[Andreas Schneider via samba-technical]

On Tuesday, 15 May 2018 05:09:20 CEST Andrew Bartlett via samba-technical

Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical

Clearing the keytab with chgtdcpass doesn't work. This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771

I've improved the all-important whitespace, some coding style issues
and commit messages.
https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest
Can I get a second team reviewer please?

Andrew I missed that there is your RB+ missing for the test. However I've
pushed it and it landed in master.


Could you confirm that you gave RB+ for both patches?


Thanks,


Andreas

[Andrew Bartlett via samba-technical]

Post by Andreas Schneider via samba-technical
On Tuesday, 15 May 2018 05:09:20 CEST Andrew Bartlett via samba-technical

Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-15 at 14:17 +1200, Aaron Haslett via samba-technical

Clearing the keytab with chgtdcpass doesn't work. This test and fix
solves the problem.
https://gitlab.com/catalyst-samba/samba/pipelines/22019771

I've improved the all-important whitespace, some coding style issues
and commit messages.
https://gitlab.com/catalyst-samba/samba/pipelines/22020990
https://gitlab.com/catalyst-samba/samba/commits/aaron-kbtest
Can I get a second team reviewer please?

Andrew I missed that there is your RB+ missing for the test. However I've
pushed it and it landed in master.
Could you confirm that you gave RB+ for both patches?

Yes, I'm fine with both patches. Glad to see them in.

Andrew Bartlett