Discussion:
[PATCH] Fix two CIDs
Volker Lendecke via samba-technical
2018-04-16 13:22:22 UTC
Permalink
Hi!

Review appreciated!

Thanks, Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:***@sernet.de
Stefan Metzmacher via samba-technical
2018-04-16 13:25:44 UTC
Permalink
Hi Volker,

as written before
https://lists.samba.org/archive/samba-technical/2018-April/126715.html

This looks wrong, in tstream_smbXcli_np_readv_trans_done()
you can also remove TALLOC_FREE(subreq), as that's already called
a few lines above, but in tstream_smbXcli_np_readv_read_done()
we need to keep this or rework smb1cli_readx_recv() to take a memory
context, so that we don't have to defer TALLOC_FREE(subreq);

The problem is that TALLOC_FREE(subreq); will crash as
it will be implicitly free'ed via the callback triggered by
tevent_req_nomem().

metze
Post by Volker Lendecke via samba-technical
Hi!
Review appreciated!
Thanks, Volker
Volker Lendecke via samba-technical
2018-04-16 13:31:22 UTC
Permalink
Post by Stefan Metzmacher via samba-technical
Hi Volker,
as written before
https://lists.samba.org/archive/samba-technical/2018-April/126715.html
Ok. Sorry for re-posting. I had missed your NACK.
Post by Stefan Metzmacher via samba-technical
This looks wrong, in tstream_smbXcli_np_readv_trans_done()
you can also remove TALLOC_FREE(subreq), as that's already called
a few lines above, but in tstream_smbXcli_np_readv_read_done()
we need to keep this or rework smb1cli_readx_recv() to take a memory
context, so that we don't have to defer TALLOC_FREE(subreq);
The problem is that TALLOC_FREE(subreq); will crash as
it will be implicitly free'ed via the callback triggered by
tevent_req_nomem().
Wow, that's really complex logic. We should turn the tevent_req_nomem
into tevent_req_oom as done elsewhere. This returns void.

Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:***@sernet.de
Volker Lendecke via samba-technical
2018-04-16 13:53:54 UTC
Permalink
Post by Volker Lendecke via samba-technical
Wow, that's really complex logic. We should turn the tevent_req_nomem
into tevent_req_oom as done elsewhere. This returns void.
Are you ok with this one?

Thanks, Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:***@sernet.de
Stefan Metzmacher via samba-technical
2018-04-16 13:58:13 UTC
Permalink
Post by Volker Lendecke via samba-technical
Post by Volker Lendecke via samba-technical
Wow, that's really complex logic. We should turn the tevent_req_nomem
into tevent_req_oom as done elsewhere. This returns void.
Are you ok with this one?
Yes, thanks! Please push:-)

metze

Loading...