Discussion:
[PATCH] Use common options for samba-tool domain provision,join,dcpromo
Andrew Bartlett via samba-technical
2018-05-14 03:48:00 UTC
Permalink
This patch set creates a common set of options for samba-tool domain
provision,join and dcpromo.

This ensures that new options are added to all these similar commands.

This addresses Denis' request for lmdb support in the domain join.

This is part of the tree under CI here:
https://gitlab.com/catalyst-samba/samba/pipelines/21953753
and here:
https://gitlab.com/catalyst-samba/samba/pipelines/21957787

Please review and push!

Thanks,

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
Gary Lockyer via samba-technical
2018-05-14 04:04:41 UTC
Permalink
Looks good to me
RB+

Gary
Post by Andrew Bartlett via samba-technical
This patch set creates a common set of options for samba-tool domain
provision,join and dcpromo.
This ensures that new options are added to all these similar commands.
This addresses Denis' request for lmdb support in the domain join.
https://gitlab.com/catalyst-samba/samba/pipelines/21953753
https://gitlab.com/catalyst-samba/samba/pipelines/21957787
Please review and push!
Thanks,
Andrew Bartlett
Andrew Bartlett via samba-technical
2018-05-15 02:42:21 UTC
Permalink
On Mon, 2018-05-14 at 16:04 +1200, Gary Lockyer via samba-technical
Post by Gary Lockyer via samba-technical
Looks good to me
RB+
Gary
Thanks Gary. Sadly the CI failed to here is the new set:

This patch set consolidates our option handling for samba-tool domain
provision,join,dcpromo.
This ensures that new options are added to all these similar commands.

This addresses Denis' request for lmdb support in the domain join.

https://gitlab.com/catalyst-samba/samba/pipelines/22016700
https://gitlab.com/catalyst-samba/samba/commits/abartlet-lmdb-pre-9

Please review and perhaps push!

Thanks,

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
Gary Lockyer via samba-technical
2018-05-15 02:52:26 UTC
Permalink
Looks good to me.

RB+

Gary
Post by Andrew Bartlett via samba-technical
On Mon, 2018-05-14 at 16:04 +1200, Gary Lockyer via samba-technical
Post by Gary Lockyer via samba-technical
Looks good to me
RB+
Gary
This patch set consolidates our option handling for samba-tool domain
provision,join,dcpromo.
This ensures that new options are added to all these similar commands.
This addresses Denis' request for lmdb support in the domain join.
https://gitlab.com/catalyst-samba/samba/pipelines/22016700
https://gitlab.com/catalyst-samba/samba/commits/abartlet-lmdb-pre-9
Please review and perhaps push!
Thanks,
Andrew Bartlett
Loading...