Discussion:
[PATCH] Begin VFS cleanup - start to remove SMB_VFS_READ calls.
Jeremy Allison via samba-technical
2018-05-01 23:29:42 UTC
Permalink
Hi Ralph and other interested parties,

Here is the first (simple) stage of the patchset
to remove SMB_VFS_READ. It removes the fiction
that Samba will work in the absense of pread
(that hasn't been true for a while), removes
an incorrect recursion call back into the VFS
from the default VFS pread code and replaces
it with it's POSIX equivalent (this is to allow
the default VFS pread call to work against a filesystem
FIFO, which returns ESPIPE on a pread()) and
then moves a function to the only caller and
makes it static.

The ugly cleanups start after this easier to
review patchset :-).

Please review and push if happy !

Cheers,

Jeremy.
Ralph Böhme via samba-technical
2018-05-02 17:32:39 UTC
Permalink
Post by Jeremy Allison via samba-technical
Hi Ralph and other interested parties,
Here is the first (simple) stage of the patchset
to remove SMB_VFS_READ. It removes the fiction
that Samba will work in the absense of pread
(that hasn't been true for a while), removes
an incorrect recursion call back into the VFS
from the default VFS pread code and replaces
it with it's POSIX equivalent (this is to allow
the default VFS pread call to work against a filesystem
FIFO, which returns ESPIPE on a pread()) and
then moves a function to the only caller and
makes it static.
The ugly cleanups start after this easier to
review patchset :-).
Please review and push if happy !
happy! Pushed. :)

-slow
--
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG Key Fingerprint: FAE2 C608 8A24 2520 51C5
59E4 AA1E 9B71 2639 9E46
Loading...