[PR PATCH] Py3 dsdb lock

[Github bot account via samba-technical]

There is a new pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

Py3 dsdb lock
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/161#issuecomment-380184917
Comment:
gah, seems like future module is not available from the ci machine :/ I think six, future etc. are essential to write python2/python3 compatible code. Othe

[Github bot account via samba-technical]

New comment by abartlet on Samba Github repository

https://github.com/samba-team/samba/pull/161#issuecomment-380208585
Comment:
Indeed, Samba has chosen to reinvent the wheel with a smaller python2/3 layer. There is a text_typ

[Github bot account via samba-technical]

New comment by abbra on Samba Github repository

https://github.com/samba-team/samba/pull/161#issuecomment-380209368
Comment:
six is essential but 'future' can be omitted. In this case you can replace future.iteritems by a native key iteration which will work in both py2 and py3:
```diff
- for key, val in global_settings.iteritems():
+ for key in global_settings:
f.write("\t%s = %s\n" % (key, global_settings[key]))
f.write("\n")
```
I'd also recommend following a Conservative Porting Guide that was developed when porting many Python applications, including majority of Samba code: http://portingguide.readthedocs.io/en/latest/index.htm

[Github bot account via samba-technical]

New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/161#issuecomment-380720855
Comment:
thanks for the pointer to the guide (trying to wrap my head around it)
hadn't come across this one

Post by Github bot account via samba-technical
six is essential but 'future' can be omitted. In this case you can
replace future.iteritems by a native key iteration which will work in
f.write("\t%s = %s\n" % (key, global_settings[key]))
f.write("\n")
I'd also recommend following a Conservative Porting Guide that was
developed when porting many Python applications, including majority of
Samba code: http://portingguide.readthedocs.io/en/latest/index.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/samba-team/samba/pull/161#issuecomment-380209368>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGIDVNeCkcGITnRYqG_eN5nqEERFrZk7ks5tnP-ugaJpZM

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

Py3 dsdb lock
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

Py3 dsdb lock
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

Py3 dsdb lock
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

Py3 dsdb lock
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/161#issuecomment-384890698
Comment:
Changing the name of this patch set, using this branch for visibility/testing purposes. I'll try to keep this branch up to date (and will rebase as necessary) with current WIP patches from my own work.
Currently I am in the process of porting individual tests, I am trying to identify wider and more generic changes from the changes necessary to get the tests to run, as I do that I am pulling those changes out into separate pull requests

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

WIP Py2/Py3 porting (not for review)
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

WIP Py2/Py3 porting (not for review)
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

WIP Py2/Py3 porting (not for review)
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached

[Github bot account via samba-technical]

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba py3_dsdb_lock
https://github.com/samba-team/samba/pull/161

WIP Py2/Py3 porting (not for review)
Changes to allow samba.tests.dsdb_lock is py2/py3 compatible. This tests a bit more some of the previous modules already ported

A patch file from https://github.com/samba-team/samba/pull/161.patch is attached