[PR PATCH] Python2 python3 compat (in lieu of 'six')

Discussion:

Github bot account via samba-technical

2018-04-25 11:44:02 UTC

There is a new pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba python2-python3-compat
https://github.com/samba-team/samba/pull/170

Python2 python3 compat (in lieu of 'six')
Some updates to samba's own compat.py to ease writing python2/python3 compatible code

A patch file from https://github.com/samba-team/samba/pull/170.patch is attached

Alexander Bokovoy via samba-technical

2018-04-25 12:31:38 UTC

Permalink

Post by Github bot account via samba-technical
There is a new pull request by noelpower against master on the Samba Samba Github repository
https://github.com/noelpower/samba python2-python3-compat
https://github.com/samba-team/samba/pull/170
Python2 python3 compat (in lieu of 'six')
Some updates to samba's own compat.py to ease writing python2/python3 compatible code
A patch file from https://github.com/samba-team/samba/pull/170.patch is attached

LGTM, RB+.

--
/ Alexander Bokovoy

Alexander Bokovoy via samba-technical

2018-04-25 12:42:05 UTC

Permalink

Post by Alexander Bokovoy via samba-technical

LGTM, RB+.

Hm.. ndr_pull_error:
```
Testing LookupSids
ndr_pull_error(1): Bad array size - got 0 expected 8
UNEXPECTED(failure): samba3.rpc.lsa.privileges.lsa.Privileges(ad_dc)
REASON: Exception: Exception: ../source4/torture/rpc/lsa.c:774: dcerpc_lsa_LookupSids_r(b, tctx, &r) was NT_STATUS_ARRAY_BOUNDS_EXCEEDED, expected NT_STATUS_OK: LookupSids failed
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
```

--
/ Alexander Bokovoy

Noel Power via samba-technical

2018-04-25 13:54:10 UTC

Permalink

Post by Alexander Bokovoy via samba-technical

LGTM, RB+.

```
Testing LookupSids
ndr_pull_error(1): Bad array size - got 0 expected 8
UNEXPECTED(failure): samba3.rpc.lsa.privileges.lsa.Privileges(ad_dc)
REASON: Exception: Exception: ../source4/torture/rpc/lsa.c:774: dcerpc_lsa_LookupSids_r(b, tctx, &r) was NT_STATUS_ARRAY_BOUNDS_EXCEEDED, expected NT_STATUS_OK: LookupSids failed
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
```

ouch, but.. nothing should be using the newly added stuff (yet)

so... hard to see how this is related. Will retry (also haven't seen
this on my own machine where I also am now running the same CI tests)
/me admits though he was running this patch with others when testing :-)

Anyway, I'll recommit to force the CI to run again (and lets see)

Noel

Github bot account via samba-technical

2018-04-25 13:57:15 UTC

Permalink

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba python2-python3-compat
https://github.com/samba-team/samba/pull/170

Python2 python3 compat (in lieu of 'six')
Some updates to samba's own compat.py to ease writing python2/python3 compatible code

A patch file from https://github.com/samba-team/samba/pull/170.patch is attached

Github bot account via samba-technical

2018-04-30 17:39:44 UTC

Permalink

There's a closed pull request on the Samba Samba Github repository

Python2 python3 compat (in lieu of 'six')
https://github.com/samba-team/samba/pull/170
Description: Some updates to samba's own compat.py to ease writing pytho

Github bot account via samba-technical

2018-04-30 17:39:44 UTC

Permalink

New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/170#issuecomment-385