Discussion:
[PATCH] script: Add 'random-seed' option to traffic_replay
(too old to reply)
Tim Beale via samba-technical
2018-05-16 05:39:19 UTC
Permalink
Hi,

The attach patch adds a new option to the traffic_replay tool that
allows you to seed the random number generator.

When you use a model-file to generate traffic, by default the tool
creates random variation in the packets that it actually generates.
However, this makes it hard to measure changes in samba performance over
time, i.e. differences could be just due to random variation in the
types/number of packets sent, rather than due to the Samba code getting
better/worse. Using the --random-seed option means an identical set of
packets gets produced across several different test runs.

Review appreciated.

Thanks,
Tim
Andrew Bartlett via samba-technical
2018-05-16 07:59:53 UTC
Permalink
Post by Tim Beale via samba-technical
Hi,
The attach patch adds a new option to the traffic_replay tool that
allows you to seed the random number generator.
When you use a model-file to generate traffic, by default the tool
creates random variation in the packets that it actually generates.
However, this makes it hard to measure changes in samba performance over
time, i.e. differences could be just due to random variation in the
types/number of packets sent, rather than due to the Samba code getting
better/worse. Using the --random-seed option means an identical set of
packets gets produced across several different test runs.
This got a positive CI result here:

https://gitlab.com/catalyst-samba/samba/pipelines/22091844

Reviewed-by: Andrew Bartlett <***@samba.org>

Can I get a second team reviewer please?

Thanks,

Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
William Brown via samba-technical
2018-05-16 08:35:15 UTC
Permalink
On Wed, 2018-05-16 at 19:59 +1200, Andrew Bartlett via samba-technical
Post by Andrew Bartlett via samba-technical
Post by Tim Beale via samba-technical
Hi,
The attach patch adds a new option to the traffic_replay tool that
allows you to seed the random number generator.
When you use a model-file to generate traffic, by default the tool
creates random variation in the packets that it actually generates.
However, this makes it hard to measure changes in samba performance over
time, i.e. differences could be just due to random variation in the
types/number of packets sent, rather than due to the Samba code getting
better/worse. Using the --random-seed option means an identical set of
packets gets produced across several different test runs.
https://gitlab.com/catalyst-samba/samba/pipelines/22091844
Can I get a second team reviewer please?
I'm not a team member, but the patch looks good to me :)
Post by Andrew Bartlett via samba-technical
Thanks,
Andrew Bartlett
Alexander Bokovoy via samba-technical
2018-05-16 08:51:41 UTC
Permalink
Post by William Brown via samba-technical
On Wed, 2018-05-16 at 19:59 +1200, Andrew Bartlett via samba-technical
Post by Andrew Bartlett via samba-technical
Post by Tim Beale via samba-technical
Hi,
The attach patch adds a new option to the traffic_replay tool that
allows you to seed the random number generator.
When you use a model-file to generate traffic, by default the tool
creates random variation in the packets that it actually generates.
However, this makes it hard to measure changes in samba performance over
time, i.e. differences could be just due to random variation in the
types/number of packets sent, rather than due to the Samba code getting
better/worse. Using the --random-seed option means an identical set of
packets gets produced across several different test runs.
https://gitlab.com/catalyst-samba/samba/pipelines/22091844
Can I get a second team reviewer please?
I'm not a team member, but the patch looks good to me :)
RB+ from my side too. Andrew, please push.
--
/ Alexander Bokovoy
Andrew Bartlett via samba-technical
2018-05-16 09:50:07 UTC
Permalink
Post by Alexander Bokovoy via samba-technical
Post by William Brown via samba-technical
On Wed, 2018-05-16 at 19:59 +1200, Andrew Bartlett via samba-technical
Post by Andrew Bartlett via samba-technical
Post by Tim Beale via samba-technical
Hi,
The attach patch adds a new option to the traffic_replay tool that
allows you to seed the random number generator.
When you use a model-file to generate traffic, by default the tool
creates random variation in the packets that it actually generates.
However, this makes it hard to measure changes in samba performance over
time, i.e. differences could be just due to random variation in the
types/number of packets sent, rather than due to the Samba code getting
better/worse. Using the --random-seed option means an identical set of
packets gets produced across several different test runs.
https://gitlab.com/catalyst-samba/samba/pipelines/22091844
Can I get a second team reviewer please?
I'm not a team member, but the patch looks good to me :)
RB+ from my side too. Andrew, please push.
Done. Thanks!

Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
Loading...