Discussion:
[PATCH] Make setexpiry test flap less
(too old to reply)
Andrew Bartlett via samba-technical
2018-05-15 02:47:18 UTC
Permalink
This test is overly sensitive to the time it takes to connect to the DC
over LDAP.

This makes the 5sec timeout be for each operation, not all of them and
should mean this isn't a flapping test anymore.

https://gitlab.com/catalyst-samba/samba/pipelines/22017570
https://gitlab.com/catalyst-samba/samba/commits/abartlet-setexpiry-less-flap

Please review and maybe push.

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
Gary Lockyer via samba-technical
2018-05-15 02:56:06 UTC
Permalink
Looks good to me

RB+

Gary
Post by Andrew Bartlett via samba-technical
This test is overly sensitive to the time it takes to connect to the DC
over LDAP.
This makes the 5sec timeout be for each operation, not all of them and
should mean this isn't a flapping test anymore.
https://gitlab.com/catalyst-samba/samba/pipelines/22017570
https://gitlab.com/catalyst-samba/samba/commits/abartlet-setexpiry-less-flap
Please review and maybe push.
Andrew Bartlett
Loading...