Discussion:
[PATCH] Extend autobuild combinations to include --without-ldap
Andrew Bartlett via samba-technical
2018-05-02 22:53:56 UTC
Permalink
Sonic, posting on the samba list, noticed recently that --without-ldap
builds fail, so this patch ensures that one of the builds we do is with
this set so that we catch that.

I've compared the test output and no tests have been lost due to this.

Please review and push.

Thanks!

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
Gary Lockyer via samba-technical
2018-05-03 02:38:00 UTC
Permalink
Looks good to me.
RB+
Post by Andrew Bartlett via samba-technical
Sonic, posting on the samba list, noticed recently that --without-ldap
builds fail, so this patch ensures that one of the builds we do is with
this set so that we catch that.
I've compared the test output and no tests have been lost due to this.
Please review and push.
Thanks!
Andrew Bartlett
Andrew Bartlett via samba-technical
2018-05-03 05:01:03 UTC
Permalink
Post by Gary Lockyer via samba-technical
Looks good to me.
RB+
Post by Andrew Bartlett via samba-technical
Sonic, posting on the samba list, noticed recently that --without-ldap
builds fail, so this patch ensures that one of the builds we do is with
this set so that we catch that.
I've compared the test output and no tests have been lost due to this.
Please review and push.
Thanks!
Andrew Bartlett
Douglas has also reviewed it and this is in autoubuild.

Thanks,

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
Loading...