Discussion:
[PATCH] Allow gitlab CI to pass without a private runner
Andrew Bartlett via samba-technical
2018-04-30 20:26:35 UTC
Permalink
G'Day,

This patch splits up our gitlab CI configuration such that the tests
that require a private runner (rather than the shared runners) do not
operate by default.

The gitlab repositories that have access to a private runner can then
use the .gitlab-ci-private.yml file via a config change.

This should make it easier for contributors to use gitlab.

The number of tests is not as good as on travis-ci, and we should work
to split those that actually need ext4 out, but this is a step forward
for now.

William,

Can you give this a test on your gitlab repo and confirm it passes for
you?

Thanks,

Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
Andrew Bartlett via samba-technical
2018-05-01 08:58:27 UTC
Permalink
On Tue, 2018-05-01 at 08:26 +1200, Andrew Bartlett via samba-technical
Post by Andrew Bartlett via samba-technical
G'Day,
This patch splits up our gitlab CI configuration such that the tests
that require a private runner (rather than the shared runners) do not
operate by default.
The gitlab repositories that have access to a private runner can then
use the .gitlab-ci-private.yml file via a config change.
This should make it easier for contributors to use gitlab.
The number of tests is not as good as on travis-ci, and we should work
to split those that actually need ext4 out, but this is a step forward
for now.
William,
Can you give this a test on your gitlab repo and confirm it passes for
you?
And now with the patch.

Thanks,

Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
William Brown via samba-technical
2018-05-02 00:39:26 UTC
Permalink
Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-01 at 08:26 +1200, Andrew Bartlett via samba-
technical
Post by Andrew Bartlett via samba-technical
G'Day,
This patch splits up our gitlab CI configuration such that the tests
that require a private runner (rather than the shared runners) do not
operate by default.
The gitlab repositories that have access to a private runner can then
use the .gitlab-ci-private.yml file via a config change.
This should make it easier for contributors to use gitlab.
The number of tests is not as good as on travis-ci, and we should work
to split those that actually need ext4 out, but this is a step forward
for now.
William,
Can you give this a test on your gitlab repo and confirm it passes for
you?
And now with the patch.
Applied, all builds/pipeline pass for me.

So I guess ... "review success". :)

William
Andrew Bartlett via samba-technical
2018-05-02 10:22:30 UTC
Permalink
Post by William Brown via samba-technical
Post by Andrew Bartlett via samba-technical
On Tue, 2018-05-01 at 08:26 +1200, Andrew Bartlett via samba-
technical
Post by Andrew Bartlett via samba-technical
G'Day,
This patch splits up our gitlab CI configuration such that the tests
that require a private runner (rather than the shared runners) do not
operate by default.
The gitlab repositories that have access to a private runner can then
use the .gitlab-ci-private.yml file via a config change.
This should make it easier for contributors to use gitlab.
And now with the patch.
Applied, all builds/pipeline pass for me.
So I guess ... "review success". :)
Thanks William,

Can I have a team member review and push the patch into master please?

Thanks,

Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
Loading...