[PR PATCH] samdb: fix wrong computer container dn for newcomputer

[Github bot account via samba-technical]

There is a new pull request by catalyst-joe-guo against master on the Samba Samba Github repository

https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173

samdb: fix wrong computer container dn for newcomputer
Fix a copy-and-paste issue for samdb.newcomputer method:

CN=Users --> CN=Computers

Signed-off-by: Joe Guo <***@catalyst.net.nz>

A patch file from https://github.com/samba-team/samba/pull/173.patch is attached

[William Brown via samba-technical]

On Thu, 2018-05-03 at 03:23 +0000, Github bot account via samba-

Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on the
Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from https://github.com/samba-team/samba/pull/173.patch is attached

Simple! Looks good to me,

William

[Alexander Bokovoy via samba-technical]

Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on the Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from https://github.com/samba-team/samba/pull/173.patch is attached

RB+. One more team reviewer, please.

[Rowland Penny via samba-technical]

On Thu, 3 May 2018 09:45:44 +0300

Post by Alexander Bokovoy via samba-technical

Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on
the Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from
https://github.com/samba-team/samba/pull/173.patch is attached

RB+. One more team reviewer, please.

Fairly obvious RB+

Rowland

[Alexander Bokovoy via samba-technical]

Post by Rowland Penny via samba-technical
On Thu, 3 May 2018 09:45:44 +0300

Post by Alexander Bokovoy via samba-technical

Post by Github bot account via samba-technical
There is a new pull request by catalyst-joe-guo against master on
the Samba Samba Github repository
https://github.com/catalyst-joe-guo/samba fix-newcomputer
https://github.com/samba-team/samba/pull/173
samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
A patch file from
https://github.com/samba-team/samba/pull/173.patch is attached

RB+. One more team reviewer, please.

Fairly obvious RB+

Thanks. Pushed to autobuild.

[Github bot account via samba-technical]

New comment by catalyst-joe-guo on Samba Github repository

https://github.com/samba-team/samba/pull/173#issuecomment-386953069
Comment:
Already merged as ca387c221f974216

[Github bot account via samba-technical]

There's a closed pull request on the Samba Samba Github repository

samdb: fix wrong computer container dn for newcomputer
https://github.com/samba-team/samba/pull/173
Description: Fix a copy-and-paste issue for samdb.newcomputer method:

CN=Users --> CN=Computers

Signed-off-by:

[Björn Baumbach via samba-technical]

Post by Github bot account via samba-technical
samdb: fix wrong computer container dn for newcomputer

Thank you for fixing this!

There is the same issue in the samba-tool computer.py code.

Patch is attached, please review and push :-)

Best regards,
Björn