Discussion:
[PR PATCH] Python2 python3 linkage issues rebase
Github bot account via samba-technical
2018-04-05 16:47:28 UTC
Permalink
There is a new pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba python2-python3-linkage-issues-rebase
https://github.com/samba-team/samba/pull/157

Python2 python3 linkage issues rebase
This patch set ensures any py3 (or whatever is specified with --extra-python) built components like the correct libraries and objects, e.g. any py3 c-module built shouldn't directly (or indirectly) link in something that would cause both libpython2 and libpython3 to both linked. Additionally the grouping library (which doesn't seem to be be used) is removed.
In order to ensure the correct libraries are linked a couple of subsystems and libraries that weren't built for py3 (but should have been) are now built (so they can be linked)

A patch file from https://github.com/samba-team/samba/pull/157.patch is attached
Github bot account via samba-technical
2018-04-06 09:22:51 UTC
Permalink
New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/157#issuecomment-379198459
Comment:
looking into this now, perhaps it is some module that for some reason doesn't built on system I wa
Github bot account via samba-technical
2018-04-06 12:08:39 UTC
Permalink
There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba python2-python3-linkage-issues-rebase
https://github.com/samba-team/samba/pull/157

Python2 python3 linkage issues rebase
This patch set ensures any py3 (or whatever is specified with --extra-python) built components like the correct libraries and objects, e.g. any py3 c-module built shouldn't directly (or indirectly) link in something that would cause both libpython2 and libpython3 to both linked. Additionally the grouping library (which doesn't seem to be be used) is removed.
In order to ensure the correct libraries are linked a couple of subsystems and libraries that weren't built for py3 (but should have been) are now built (so they can be linked)

A patch file from https://github.com/samba-team/samba/pull/157.patch is attached
Github bot account via samba-technical
2018-04-06 12:11:39 UTC
Permalink
New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/157#issuecomment-379234667
Comment:
seems this is due to the way the build is split on the ci (with separate build/deliver) for ldb/talloc/tevent + core samba. I tried to reproduce this (by building in a similar way, previously I was just building everything from the main samba dir), I get a similar error (but not the same)
I fixed that error locally and am h
Github bot account via samba-technical
2018-04-06 13:45:01 UTC
Permalink
New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/157#issuecomment-379257634
Comment:
hmm failed again (but ci failures don't seem related), I am hoping rebasing against latest master
Github bot account via samba-technical
2018-04-06 13:45:50 UTC
Permalink
There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba python2-python3-linkage-issues-rebase
https://github.com/samba-team/samba/pull/157

Python2 python3 linkage issues rebase
This patch set ensures any py3 (or whatever is specified with --extra-python) built components like the correct libraries and objects, e.g. any py3 c-module built shouldn't directly (or indirectly) link in something that would cause both libpython2 and libpython3 to both linked. Additionally the grouping library (which doesn't seem to be be used) is removed.
In order to ensure the correct libraries are linked a couple of subsystems and libraries that weren't built for py3 (but should have been) are now built (so they can be linked)

A patch file from https://github.com/samba-team/samba/pull/157.patch is attached
Github bot account via samba-technical
2018-04-06 16:41:45 UTC
Permalink
There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba python2-python3-linkage-issues-rebase
https://github.com/samba-team/samba/pull/157

Python2 python3 linkage issues rebase
This patch set ensures any py3 (or whatever is specified with --extra-python) built components like the correct libraries and objects, e.g. any py3 c-module built shouldn't directly (or indirectly) link in something that would cause both libpython2 and libpython3 to both linked. Additionally the grouping library (which doesn't seem to be be used) is removed.
In order to ensure the correct libraries are linked a couple of subsystems and libraries that weren't built for py3 (but should have been) are now built (so they can be linked)

A patch file from https://github.com/samba-team/samba/pull/157.patch is attached
Github bot account via samba-technical
2018-04-06 18:11:15 UTC
Permalink
New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/157#issuecomment-379333304
Comment:
This patch set now passes CI, it eliminates the incorrect simultaneous linking of both libpython2/
Noel Power via samba-technical
2018-04-10 09:30:16 UTC
Permalink
Post by Github bot account via samba-technical
New comment by noelpower on Samba Github repository
https://github.com/samba-team/samba/pull/157#issuecomment-379333304
This patch set now passes CI, it eliminates the incorrect simultaneous linking of both libpython2/libpython3 in python3 c - modules.
Any help getting this reviewed appreciated
Github bot account via samba-technical
2018-04-26 09:17:52 UTC
Permalink
There's a closed pull request on the Samba Samba Github repository

Python2 python3 linkage issues rebase
https://github.com/samba-team/samba/pull/157
Description: This patch set ensures any py3 (or whatever is specified with --extra-python) built components like the correct libraries and objects, e.g. any py3 c-module built shouldn't directly (or indirectly) link in something that would cause both libpython2 and libpython3 to both linked. Additionally the grouping library (which doesn't seem to be be used) is removed.
In order to ensure the correct libraries are linked a couple of subsystems and libraries that weren't built for py3 (but should have been) are now built (so t
Github bot account via samba-technical
2018-04-26 09:17:52 UTC
Permalink
New comment by noelpower on Samba Github repository

https://github.com/samba-team/samba/pull/157#issuecomment-384572024
Comment:
has been integrated via another pull requ

Loading...