[PATCH] fix for https://bugzilla.samba.org/show_bug.cgi?id=13435

[Noel Power via samba-technical]

Hi,

Please have a look at the attached patch for 
https://bugzilla.samba.org/show_bug.cgi?id=13435

comments welcome

also please see

https://github.com/samba-team/samba/pull/187

https://travis-ci.org/samba-team/samba/builds/378783222?utm_source=github_status&utm_medium=notification


Noel

[Andrew Bartlett via samba-technical]

Post by Noel Power via samba-technical
Hi,
Please have a look at the attached patch for
https://bugzilla.samba.org/show_bug.cgi?id=13435
comments welcome
also please see
https://github.com/samba-team/samba/pull/187
https://travis-ci.org/samba-team/samba/builds/378783222?utm_source=github_status&utm_medium=notification

Thanks Noel,

Reviewed-by: Andrew Bartlett <***@samba.org>

Please push!

Andrew Bartlett

[Stefan Metzmacher via samba-technical]

Post by Andrew Bartlett via samba-technical

Post by Noel Power via samba-technical
Hi,
Please have a look at the attached patch for
https://bugzilla.samba.org/show_bug.cgi?id=13435
comments welcome
also please see
https://github.com/samba-team/samba/pull/187
https://travis-ci.org/samba-team/samba/builds/378783222?utm_source=github_status&utm_medium=notification

Thanks Noel,

Can we have a test that actually tries to use the password?

metze

[Andrew Bartlett via samba-technical]

So, in general I think probably changing any usage of format "s" to "es"
in our python modules to ensure strings passed as unicode in py2
actually can get transported without getting scuppered by default
encoding is necessary. I intend to do a bulk change for that soon
(assuming that noone thinks that is a crazy idea)
Also I don't think we are finished with problems specifically with
handling of incorrect password/str encoding. I've spotted a couple of
more instances that look dubious that I am looking into

Thank you so much for your patience and persistence with this.

See my patch on the other thread.

Andrew Bartlett