Discussion:
[PR PATCH] Check "auth event notification" param in log_json
Github bot account via samba-technical
2018-04-11 19:49:03 UTC
Permalink
There is a new pull request by reqa against master on the Samba Samba Github repository

https://github.com/reqa/samba auth_event_notification
https://github.com/samba-team/samba/pull/162

Check "auth event notification" param in log_json
When Samba is compiled with JSON support it logs an error message
at log level 3 by default for every authentication event:

get_auth_event_server: Failed to find 'auth_event' registered on the
message bus to send JSON authentication events to:
NT_STATUS_OBJECT_NAME_NOT_FOUND

This patch adjusts the log_json function to consider the smb.conf
parameter "auth event notification" before calling auth_message_send.

Signed-off-by: Arvid Requate <***@univention.de>

A patch file from https://github.com/samba-team/samba/pull/162.patch is attached
Gary Lockyer via samba-technical
2018-04-12 00:10:36 UTC
Permalink
Passes CI, results at
https://gitlab.com/catalyst-samba/samba/pipelines/20353491

RB+

Can I get a second team review
Gary
Post by Github bot account via samba-technical
There is a new pull request by reqa against master on the Samba Samba Github repository
https://github.com/reqa/samba auth_event_notification
https://github.com/samba-team/samba/pull/162
Check "auth event notification" param in log_json
When Samba is compiled with JSON support it logs an error message
get_auth_event_server: Failed to find 'auth_event' registered on the
NT_STATUS_OBJECT_NAME_NOT_FOUND
This patch adjusts the log_json function to consider the smb.conf
parameter "auth event notification" before calling auth_message_send.
A patch file from https://github.com/samba-team/samba/pull/162.patch is attached
Github bot account via samba-technical
2018-04-13 02:37:41 UTC
Permalink
There's a closed pull request on the Samba Samba Github repository

Check "auth event notification" param in log_json
https://github.com/samba-team/samba/pull/162
Description: When Samba is compiled with JSON support it logs an error message
at log level 3 by default for every authentication event:

get_auth_event_server: Failed to find 'auth_event' registered on the
message bus to send JSON authentication events to:
NT_STATUS_OBJECT_NAME_NOT_FOUND

This patch adjusts the log_json function to consider the smb.conf
parameter "auth event notification" before calling auth_message_send.

Signed-off-by: Arvid Requa
Github bot account via samba-technical
2018-04-13 02:37:35 UTC
Permalink
New comment by abartlet on Samba Github repository

https://github.com/samba-team/samba/pull/162#issuecomment-381003605
Comment:
Merged as 228d0430d59d26ae12d1f2ab7082f86fa10d5ba0 in master for Samba 4.9.

BUG: https://bugzill

Loading...