Discussion:
[PR PATCH] Add missing refpurpose of vfs_linux_xfs_sgid manpage
Github bot account via samba-technical
2018-05-01 18:39:42 UTC
Permalink
There is a new pull request by sathieu against master on the Samba Samba Github repository

https://github.com/sathieu/samba vfs_linux_xfs_sgid-manpage
https://github.com/samba-team/samba/pull/172

Add missing refpurpose of vfs_linux_xfs_sgid manpage
Signed-off-by: Mathieu Parent <***@gmail.com>

A patch file from https://github.com/samba-team/samba/pull/172.patch is attached
Github bot account via samba-technical
2018-05-01 18:41:50 UTC
Permalink
New comment by sathieu on Samba Github repository

https://github.com/samba-team/samba/pull/172#issuecomment-385752818
Each manual page should start with a "NAME" section, which lists the name and a brief description of the page separated by "\-". The "NAME" section is parsed by lexgrog and used to generate a database that's queried by commands like apropos and whatis. This tag indicates that lexgrog was unable to parse the NAME section of this manual page.
For manual pages that document multiple programs, functions, files, or other things, the part before "\-" should list each separated by a comma and a space. Each thing listed must not contain spaces; a man page for a two-part command like "fs listacl" must use something like "fs_listacl" in the "NAME" section so that it can be parsed by lexgrog.
Refer to the lexgrog(1) manual page, the groff_man(7) manual page, and the
Volker Lendecke via samba-technical
2018-05-02 08:14:09 UTC
Permalink
Post by Github bot account via samba-technical
There is a new pull request by sathieu against master on the Samba Samba Github repository
https://github.com/sathieu/samba vfs_linux_xfs_sgid-manpage
https://github.com/samba-team/samba/pull/172
Add missing refpurpose of vfs_linux_xfs_sgid manpage
A patch file from https://github.com/samba-team/samba/pull/172.patch is attached
Can we be a bit more specific about those circumstances?

Thanks,

Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:***@sernet.de
Christoph Hellwig via samba-technical
2018-05-02 13:23:27 UTC
Permalink
+ <refpurpose>Workaround XFS SGID bit not inherited under certain circumstances</refpurpose>
And what would those circumstances be?
Github bot account via samba-technical
2018-05-02 19:00:28 UTC
Permalink
New comment by sathieu on Samba Github repository

https://github.com/samba-team/samba/pull/172#issuecomment-386085156
this should be fixed in kernel 3.11 by commit 42c49d7f249c2487f36d3314753d5d8ebcee8249
And according to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42c49d7f249c2487f36d3314753d5d8ebcee8249, the bug was during mkdir when a default acl was set.

Proposed refpurpose:
```
Workaround XFS sgid bit not inherited during mkdir with default acls on Linux older than 3.11
```
I'm not english native. Any rewording
Github bot account via samba-technical
2018-05-04 15:24:03 UTC
Permalink
There is an updated pull request by sathieu against master on the Samba Samba Github repository

https://github.com/sathieu/samba vfs_linux_xfs_sgid-manpage
https://github.com/samba-team/samba/pull/172

Add missing refpurpose of vfs_linux_xfs_sgid manpage
Signed-off-by: Mathieu Parent <***@gmail.com>

A patch file from https://github.com/samba-team/samba/pull/172.patch is attached
Loading...